-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): Button ring on focus #1238
Conversation
fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
- Coverage 99.54% 97.36% -2.18%
==========================================
Files 163 214 +51
Lines 6621 9077 +2456
Branches 401 530 +129
==========================================
+ Hits 6591 8838 +2247
- Misses 30 239 +209 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ggwp
fix(button): fix button ring on focus fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
fix(button): fix button ring on focus fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
Summarize the changes made and the motivation behind them.
This PR fixes the button focus ring, which is currently inconsistent with the core library. The Button Group ring was wrongly overriding the ring-4 classes defined in the button themes.
Also, I took the opportunity to add a slight transition on the button colors/shadows to have the hover and the ring styles animated
Reference related issues using
#
followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.